oboeru

Commit: 4eae999de673b348d5c94323a48d15924e4e0804
Parent: 9f3ef399f0ebfd385243a235b5e6b5677efe2c06
Author: Randy Palamar
Date:   Sun, 22 Aug 2021 14:36:06 -0600

oboeru: shuffle after adding review in review loop

Diffstat:
M
oboeru.c
 | 
15
+++++++++------

1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/oboeru.c b/oboeru.c
@@ -200,19 +200,19 @@ bump_card(Card *card, int8_t status)
 }
 
 static void
-shuffle_reviews(Card *r[])
+shuffle_reviews(Card *r[], size_t n)
 {
 	size_t i, j;
 	Card *t;
 
-	if (n_reviews <= 1)
+	if (n <= 1)
 		return;
 
 	srand(time(NULL));
 
 	/* this could be improved */
-	for (i = 0; i < n_reviews; i++) {
-		j = i + rand() % (n_reviews - i);
+	for (i = 0; i < n; i++) {
+		j = i + rand() % (n - i);
 
 		t = r[j];
 		r[j] = r[i];
@@ -256,8 +256,11 @@ review_loop(Card *r[], const char *decks[], const char *fifo)
 				r[i]->nobump = bump_card(r[i], reply_map[j].status);
 
 		/* if the card wasn't bumped it needs an extra review */
-		if (r[i]->nobump)
+		if (r[i]->nobump) {
 			r = add_review(r, r[i]);
+			/* r[i+1] exists because we have added a review */
+			shuffle_reviews(&r[i + 1], n_reviews - i - 1);
+		}
 
 		/* give the writing process time to close its fd */
 		nanosleep(&wait, NULL);
@@ -351,7 +354,7 @@ main(int argc, char *argv[])
 		die("Cards Due: %ld\n", n_reviews);
 	}
 
-	shuffle_reviews(reviews);
+	shuffle_reviews(reviews, n_reviews);
 	reviews = review_loop(reviews, decks, fifo);
 
 	/* write updated data into deck files */